Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1778 - heat of mixing #2837

Merged
merged 55 commits into from
Jun 21, 2024
Merged

Issue 1778 - heat of mixing #2837

merged 55 commits into from
Jun 21, 2024

Commits on Mar 17, 2023

  1. fix

    @aabills
    aabills committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    e06d5b9 View commit details
    Browse the repository at this point in the history

  2. fix exception

    @aabills
    aabills committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    688c9a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Merge branch 'pybamm-team:develop' into energy-summary

    @aabills
    aabills authored Mar 29, 2023
    Configuration menu
    Copy the full SHA
    0d84720 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'pybamm-team:develop' into issue-1778

    @aabills
    aabills authored Mar 29, 2023
    Configuration menu
    Copy the full SHA
    1cd0655 View commit details
    Browse the repository at this point in the history

  3. added a Newfile

    @smitasahu2
    smitasahu2 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    6dbe8d6 View commit details
    Browse the repository at this point in the history

  4. pseudo

    @aabills
    aabills committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    69e6ba6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'issue-1778' of github.com:abillscmu/PyBaMM into issue-1778

    @aabills
    aabills committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    fccea75 View commit details
    Browse the repository at this point in the history

  6. pybamm-team#1778 add heat of mixing option

    @Afgr1087
    Afgr1087 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    beb5205 View commit details
    Browse the repository at this point in the history

  7. pybamm-team#1778 fixed indentation

    @Afgr1087
    Afgr1087 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    161dc82 View commit details
    Browse the repository at this point in the history

  8. pybamm-team#1778 fixed test

    @Afgr1087
    Afgr1087 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    93777da View commit details
    Browse the repository at this point in the history

  9. pybamm-team#1778 fixed test

    @Afgr1087
    Afgr1087 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    908632a View commit details
    Browse the repository at this point in the history

  10. pybamm-team#1788 added heat of mixing tests

    @brosaplanella
    brosaplanella committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    6c92466 View commit details
    Browse the repository at this point in the history

  11. First commit

    @ikorotkin
    ikorotkin committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    0da6f2e View commit details
    Browse the repository at this point in the history

  12. pybamm-team#1778 fixed test

    @Afgr1087
    Afgr1087 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    35f96e3 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'issue-1778-test' of github.com:abillscmu/PyBaMM into is… 

    …sue-1778-test
    @brosaplanella
    brosaplanella committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    f39cc6f View commit details
    Browse the repository at this point in the history

  14. First iteration

    @ikorotkin
    ikorotkin committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    f6fc9d1 View commit details
    Browse the repository at this point in the history

  15. Merge pull request #5 from abillscmu/issue-1778-test 

    pybamm-team#1778 add heat of mixing option
    @aabills
    aabills authored Mar 29, 2023
    Configuration menu
    Copy the full SHA
    53d3078 View commit details
    Browse the repository at this point in the history

  16. pybamm-team#1788 try to fix diff of U

    @brosaplanella
    brosaplanella committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2463a0b View commit details
    Browse the repository at this point in the history

  17. first push from mac

    @smitasahu2
    smitasahu2 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    dda5340 View commit details
    Browse the repository at this point in the history

  18. Fixed full broadcast

    @ikorotkin
    ikorotkin committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    549e1e2 View commit details
    Browse the repository at this point in the history

  19. Fixed domain in the integral

    @ikorotkin
    ikorotkin committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    67a2e34 View commit details
    Browse the repository at this point in the history

  20. pybamm-team#1778 fix parameter values example

    @brosaplanella
    brosaplanella committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    33e8726 View commit details
    Browse the repository at this point in the history

  21. Added children[0].children[0]

    @ikorotkin
    ikorotkin committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    c60d6eb View commit details
    Browse the repository at this point in the history

  22. Added half cell

    @ikorotkin
    ikorotkin committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    cd1f868 View commit details
    Browse the repository at this point in the history

  23. Merge branch 'pybamm-team:develop' into issue-1778

    @aabills
    aabills authored Mar 29, 2023
    Configuration menu
    Copy the full SHA
    7c1812d View commit details
    Browse the repository at this point in the history

  24. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    4bc354e View commit details
    Browse the repository at this point in the history

  25. pybamm-team#1788 revert some unrelated changes

    @brosaplanella
    brosaplanella committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    d2e6274 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. change ocv hack

    @aabills
    aabills committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    3ad0c75 View commit details
    Browse the repository at this point in the history

  2. Revert "change ocv hack" 

    This reverts commit 3ad0c75.
    @aabills
    aabills committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    537b2bf View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Merge branch 'develop' into issue-1778

    @brosaplanella
    brosaplanella committed May 23, 2023
    Configuration menu
    Copy the full SHA
    a5e3b06 View commit details
    Browse the repository at this point in the history

  2. pybamm-team#1778 fix heat of mixing

    @brosaplanella
    brosaplanella committed May 23, 2023
    Configuration menu
    Copy the full SHA
    9817dfc View commit details
    Browse the repository at this point in the history

  3. pybamm-team#1839 fix thermal submodels to take x_average

    @brosaplanella
    brosaplanella committed May 23, 2023
    Configuration menu
    Copy the full SHA
    7881045 View commit details
    Browse the repository at this point in the history

  4. pybamm-team#1778 add example heat of mixing

    @brosaplanella
    brosaplanella committed May 23, 2023
    Configuration menu
    Copy the full SHA
    969b464 View commit details
    Browse the repository at this point in the history

  5. ruff

    @brosaplanella
    brosaplanella committed May 23, 2023
    Configuration menu
    Copy the full SHA
    c07899d View commit details
    Browse the repository at this point in the history

  6. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e910e77 View commit details
    Browse the repository at this point in the history

  7. pybamm-team#1778 fix lead acid models

    @brosaplanella
    brosaplanella committed May 23, 2023
    Configuration menu
    Copy the full SHA
    6402448 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. fix SPM with the right broadcast of temperature

    @brosaplanella
    brosaplanella committed May 24, 2023
    Configuration menu
    Copy the full SHA
    00cee21 View commit details
    Browse the repository at this point in the history

  2. pybamm-team#1778 refactor heat of mixing

    @brosaplanella
    brosaplanella committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7d54a60 View commit details
    Browse the repository at this point in the history

  3. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed May 24, 2023
    Configuration menu
    Copy the full SHA
    8380ec4 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Add Richardson2021 citation for heat of mixing

    @ikorotkin
    ikorotkin committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    76bae06 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Fixed heat of mixing sign

    @ikorotkin
    ikorotkin committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    bb6134e View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. Rewritten heat of mixing example, added comparison plot to compare wi… 

    …th the paper
    @ikorotkin
    ikorotkin committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    442f2d4 View commit details
    Browse the repository at this point in the history

  2. Fixed ruff formatting errors in the heat of mixing example script

    @ikorotkin
    ikorotkin committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    cfaf2c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Merge remote-tracking branch 'upstream/develop' into issue-1778

    @brosaplanella
    brosaplanella committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    420bb78 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'issue-1778' of github.com:abillscmu/PyBaMM into issue-1778

    @brosaplanella
    brosaplanella committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    e90356e View commit details
    Browse the repository at this point in the history

  3. pybamm-team#1778 fix x-full

    @brosaplanella
    brosaplanella committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    65d4a08 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Merge remote-tracking branch 'upstream/develop' into issue-1778

    @brosaplanella
    brosaplanella committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    892ed8f View commit details
    Browse the repository at this point in the history

  2. pybamm-team#1778 fix tests

    @brosaplanella
    brosaplanella committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d894297 View commit details
    Browse the repository at this point in the history

  3. pybamm-team#1778 improve coverage

    @brosaplanella
    brosaplanella committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    f1605bd View commit details
    Browse the repository at this point in the history

  4. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    5818458 View commit details
    Browse the repository at this point in the history

  5. pybamm-team#1778 Valentin's suggestion to remove the dUdsto function … 

    …and compute the derivative in the model directly instead
    @brosaplanella
    brosaplanella committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8ab206a View commit details
    Browse the repository at this point in the history

  6. pybamm-team#1778 fix failing test

    @brosaplanella
    brosaplanella committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    accde29 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'issue-1778' of github.com:abillscmu/PyBaMM into issue-1778

    @brosaplanella
    brosaplanella committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2c7e8df View commit details
    Browse the repository at this point in the history

  8. pybamm-team#1778 add heat of mixing to CHANGELOG

    @brosaplanella
    brosaplanella committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a1b05bd View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge branch 'develop' into issue-1778

    @brosaplanella
    brosaplanella authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a88c897 View commit details
    Browse the repository at this point in the history