Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2789 add "all" to sensitivities for idaklu solver #2883

Merged
merged 4 commits into from
Apr 19, 2023

Conversation

martinjrobins
Copy link
Contributor

@martinjrobins martinjrobins commented Apr 19, 2023

Description

Partially fixes #2789 and unblocks #2858

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1d6bd48) 99.69% compared to head (d3391b0) 99.69%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2883   +/-   ##
========================================
  Coverage    99.69%   99.69%           
========================================
  Files          273      273           
  Lines        19083    19084    +1     
========================================
+ Hits         19024    19025    +1     
  Misses          59       59           
Impacted Files Coverage Δ
pybamm/solvers/idaklu_solver.py 98.99% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valentinsulzer valentinsulzer merged commit 31ec93c into develop Apr 19, 2023
@valentinsulzer valentinsulzer deleted the i2789-short-discharge branch April 19, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Short discharge pulse in drive cycle partially ignored
2 participants