Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idaklu solver can be given a list of variables to calculate during the solve #3217

Merged
merged 45 commits into from
Sep 29, 2023
Merged

Idaklu solver can be given a list of variables to calculate during the solve #3217

merged 45 commits into from
Sep 29, 2023

Commits on Jul 14, 2023

  1. Refactor of idaklu code

    @jsbrittain
    jsbrittain committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    36a7275 View commit details
    Browse the repository at this point in the history

  2. Add convenience test code (quick compile & run)

    @jsbrittain
    jsbrittain committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    e693cef View commit details
    Browse the repository at this point in the history

  3. Add CSR support to idaklu solver

    @jsbrittain
    jsbrittain committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    97e7e0d View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Add initial support for a list of variables' functions in idaklu

    @jsbrittain
    jsbrittain committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    201ec7f View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2023

  1. Collate vars or state vectors in idaklu; refactor Solution class stru… 

    …cture ready for separate vars and state-vector implementations
    @jsbrittain
    jsbrittain committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    74def04 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Fix incorrect input structure being passed when building variables' c… 

    …asadi functions
    @jsbrittain
    jsbrittain committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    df9568d View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Calculate sensitivities in Idaklu; uses temporary return structure

    @jsbrittain
    jsbrittain committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    9cb6cd3 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Provide new ProcessedVariable class when output_variables are specified

    @jsbrittain
    jsbrittain committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c8ad3c4 View commit details
    Browse the repository at this point in the history

  2. Variables now correctly unroll in the ProcessedVariablesVar class

    @jsbrittain
    jsbrittain committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    d7de190 View commit details
    Browse the repository at this point in the history

  3. Reshape sensitivities using base variable parameters

    @jsbrittain
    jsbrittain committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ef90a61 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Ensure further compatibility with existing tests

    @jsbrittain
    jsbrittain committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    c35fbae View commit details
    Browse the repository at this point in the history

  2. Add unit tests for ProcessedVariableVar and modify Solution class tes… 

    …ts to include output_variables where relevant
    @jsbrittain
    jsbrittain committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    80d845e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'pybamm-team:develop' into solver

    @jsbrittain
    jsbrittain authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    7e3ea66 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Account for ExplicitTimeIntegral variables

    @jsbrittain
    jsbrittain committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    3dfbc15 View commit details
    Browse the repository at this point in the history

  2. Remove developer quicktest code

    @jsbrittain
    jsbrittain committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    f09ca6d View commit details
    Browse the repository at this point in the history

  3. Code formatting

    @jsbrittain
    jsbrittain committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    bc2e162 View commit details
    Browse the repository at this point in the history

  4. Update changelog

    @jsbrittain
    jsbrittain committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    aadc287 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'pybamm-team:develop' into solver

    @jsbrittain
    jsbrittain authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    1c83d00 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Resolve merge conflict

    @jsbrittain
    jsbrittain committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    16c80ca View commit details
    Browse the repository at this point in the history

  2. Pre-commit tidy-up

    @jsbrittain
    jsbrittain committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    58cee45 View commit details
    Browse the repository at this point in the history

  3. Improve testing / code-coverage

    @jsbrittain
    jsbrittain committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    2fb4e55 View commit details
    Browse the repository at this point in the history

  4. Codacy improvements

    @jsbrittain
    jsbrittain committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    437a488 View commit details
    Browse the repository at this point in the history

  5. Codacy improvements

    @jsbrittain
    jsbrittain committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    74f06f6 View commit details
    Browse the repository at this point in the history

  6. Additional tests for idaklu solver with output_variables

    @jsbrittain
    jsbrittain committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    89222a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Improve test coverage

    @jsbrittain
    jsbrittain committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    d028668 View commit details
    Browse the repository at this point in the history

  2. Generalise idaklu matrix format conversions

    @jsbrittain
    jsbrittain committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    86b9c01 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Merge branch 'pybamm-team:develop' into solver

    @jsbrittain
    jsbrittain authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    b9b6d03 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Suggested changes

    @jsbrittain
    jsbrittain committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    653dc1d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Improve documentation in idaklu solver

    @jsbrittain
    jsbrittain committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    f442fb1 View commit details
    Browse the repository at this point in the history

  2. Refactor CasadiFunctionsOpenMP concrete implementations to macro gene… 

    …rator
    @jsbrittain
    jsbrittain committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    38e4a06 View commit details
    Browse the repository at this point in the history

  3. Reinforce appropriate access rights (provide getters) for function ac… 

    …cess in idaklu casadi_functions.hpp
    @jsbrittain
    jsbrittain committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    bb56bea View commit details
    Browse the repository at this point in the history

  4. Rename ProcessedVariableVar class to ProcessedVariableComputed and up… 

    …date docstring
    @jsbrittain
    jsbrittain committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    21d68be View commit details
    Browse the repository at this point in the history

  5. Move casadi variable and sensitivity functions to the BaseSolver class

    @jsbrittain
    jsbrittain committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ab98190 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'pybamm-team:develop' into solver

    @jsbrittain
    jsbrittain authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2e59e71 View commit details
    Browse the repository at this point in the history

  7. Update test functions for ProcessedVariableComputed class

    @jsbrittain
    jsbrittain committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    f9b709a View commit details
    Browse the repository at this point in the history

  8. Fix IdakluSolver issue overwriting casadi functions and add additiona… 

    …l sensitivity tests when output_variables are specified
    @jsbrittain
    jsbrittain committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c3e4218 View commit details
    Browse the repository at this point in the history

  9. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    5c52220 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Fix IDAKLUSolver crash on successive runs

    @jsbrittain
    jsbrittain committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2187b89 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Refactor variable generation through the standard process() function

    @jsbrittain
    jsbrittain committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7f9aa24 View commit details
    Browse the repository at this point in the history

  2. Pre-commit fixes

    @jsbrittain
    jsbrittain committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f381e31 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Streamline base_solver process()

    @jsbrittain
    jsbrittain committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    174bec4 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Merge branch 'pybamm-team:develop' into solver

    @jsbrittain
    jsbrittain authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    67f825b View commit details
    Browse the repository at this point in the history

  2. Separate idaklu implementation classes

    @jsbrittain
    jsbrittain committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e8ff644 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Codacy improvements

    @jsbrittain
    jsbrittain committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    9ac8383 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Merge branch 'pybamm-team:develop' into solver

    @jsbrittain
    jsbrittain authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    c7d109b View commit details
    Browse the repository at this point in the history