Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for i686 manylinux #3412

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Drop support for i686 manylinux #3412

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8049a5
Drop support for i686 manylinux, use `build` for sdist
agriyakhetarpal Oct 5, 2023
390b47f
Update changelog about dropping 32-bit Linux support
agriyakhetarpal Oct 5, 2023
319d0b4
Remove comments and notes about BLAS
agriyakhetarpal Oct 5, 2023
0893769
Bump SuiteSparse to 6.0.3
Saransh-cpp Oct 5, 2023
245a3fa
Try fixing KLU paths
Saransh-cpp Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/publish_pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ jobs:
- name: Build wheels on Linux and MacOS
run: python -m cibuildwheel --output-dir wheelhouse
env:
# NumPy requires BLAS now which is no longer available on manylinux2014 i686, so skip it
CIBW_ARCHS_LINUX: x86_64
# TODO: openblas no longer available on centos 7 i686 image, use blas instead for now
CIBW_BEFORE_ALL_LINUX: >
yum -y install blas-devel lapack-devel &&
agriyakhetarpal marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -135,13 +137,13 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.11

- name: Install dependencies
run: pip install wheel
run: pip install --upgrade pip setuptools wheel build

- name: Build sdist
run: python setup.py sdist --formats=gztar
run: python -m build --sdist

- name: Upload sdist
uses: actions/upload-artifact@v3
Expand Down Expand Up @@ -171,13 +173,13 @@ jobs:
with:
user: __token__
password: ${{ secrets.PYPI_TOKEN }}
packages_dir: files/
packages-dir: files/

- name: Publish on TestPyPI
if: github.event.inputs.target == 'testpypi'
uses: pypa/gh-action-pypi-publish@release/v1
with:
user: __token__
password: ${{ secrets.TESTPYPI_TOKEN }}
packages_dir: files/
repository_url: https://test.pypi.org/legacy/
packages-dir: files/
repository-url: https://test.pypi.org/legacy/
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@

## Breaking changes

- Dropped support for i686 (32-bit) architectures on GNU/Linux distributions ([#3412](https://github.com/pybamm-team/PyBaMM/pull/3412))
- The class `pybamm.thermal.OneDimensionalX` has been moved to `pybamm.thermal.pouch_cell.OneDimensionalX` to reflect the fact that the model formulation implicitly assumes a pouch cell geometry ([#3257](https://github.com/pybamm-team/PyBaMM/pull/3257))
- The "lumped" thermal option now always used the parameters "Cell cooling surface area [m2]", "Cell volume [m3]" and "Total heat transfer coefficient [W.m-2.K-1]" to compute the cell cooling regardless of the chosen "cell geometry" option. The user must now specify the correct values for these parameters instead of them being calculated based on e.g. a pouch cell. An `OptionWarning` is raised to let users know to update their parameters ([#3257](https://github.com/pybamm-team/PyBaMM/pull/3257))
- Numpy functions now work with PyBaMM symbols (e.g. `np.exp(pybamm.Symbol("a"))` returns `pybamm.Exp(pybamm.Symbol("a"))`). This means that parameter functions can be specified using numpy functions instead of pybamm functions. Additionally, combining numpy arrays with pybamm objects now works (the numpy array is converted to a pybamm array) ([#3205](https://github.com/pybamm-team/PyBaMM/pull/3205))
Expand Down
Loading