Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows unit and integration tests failures #3454

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix Windows unit and integration tests failures #3454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/run_periodic_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,44 +84,44 @@ jobs:
if: matrix.os == 'windows-latest'
run: choco install graphviz --version=2.38.0.20190211

- name: Install standard python dependencies
- name: Install standard Python dependencies
run: |
python -m pip install --upgrade pip wheel setuptools nox
python -m pip install --upgrade pip wheel setuptools

- name: Install SuiteSparse and SUNDIALS on GNU/Linux
if: matrix.os == 'ubuntu-latest'
run: nox -s pybamm-requires
run: pipx run nox -s pybamm-requires

- name: Run unit tests for GNU/Linux with Python 3.8, 3.9, and 3.10, and for macOS and Windows with all Python versions
if: (matrix.os == 'ubuntu-latest' && matrix.python-version != 3.11) || (matrix.os != 'ubuntu-latest')
run: nox -s unit
run: pipx run nox -s unit

- name: Run unit tests for GNU/Linux with Python 3.11 and generate coverage report
if: matrix.os == 'ubuntu-latest' && matrix.python-version == 3.11
run: nox -s coverage
run: pipx run nox -s coverage

- name: Upload coverage report
if: matrix.os == 'ubuntu-latest' && matrix.python-version == 3.11
uses: codecov/codecov-action@v3.1.4

- name: Run integration tests
run: nox -s integration
run: pipx run nox -s integration

- name: Install docs dependencies and run doctests
if: matrix.os == 'ubuntu-latest'
run: nox -s doctests
run: pipx run nox -s doctests

- name: Check if the documentation can be built
if: matrix.os == 'ubuntu-latest'
run: nox -s docs
run: pipx run nox -s docs

- name: Install dev dependencies and run example tests
if: matrix.os == 'ubuntu-latest'
run: nox -s examples
run: pipx run nox -s examples

- name: Run example scripts tests
if: matrix.os == 'ubuntu-latest'
run: nox -s scripts
run: pipx run nox -s scripts

#M-series Mac Mini
build-apple-mseries:
Expand Down
34 changes: 17 additions & 17 deletions .github/workflows/test_on_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:

- name: Install PyBaMM dependencies
run: |
pip install --upgrade pip wheel setuptools nox
pip install --upgrade pip wheel setuptools
pip install -e .[all,docs]

- name: Cache pybamm-requires nox environment for GNU/Linux
Expand All @@ -111,10 +111,10 @@ jobs:

- name: Install SuiteSparse and SUNDIALS on GNU/Linux
if: matrix.os == 'ubuntu-latest'
run: nox -s pybamm-requires
run: pipx run nox -s pybamm-requires

- name: Run unit tests for ${{ matrix.os }} with Python ${{ matrix.python-version }}
run: nox -s unit
run: pipx run nox -s unit

# Runs only on Ubuntu with Python 3.11
check_coverage:
Expand Down Expand Up @@ -169,10 +169,10 @@ jobs:
key: nox-pybamm-requires-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/install_KLU_Sundials.py') }}

- name: Install SuiteSparse and SUNDIALS on GNU/Linux
run: nox -s pybamm-requires
run: pipx run nox -s pybamm-requires

- name: Run unit tests for Ubuntu with Python 3.11 and generate coverage report
run: nox -s coverage
run: pipx run nox -s coverage

- name: Upload coverage report
uses: codecov/codecov-action@v3.1.4
Expand Down Expand Up @@ -235,7 +235,7 @@ jobs:

- name: Install PyBaMM dependencies
run: |
pip install --upgrade pip wheel setuptools nox
pip install --upgrade pip wheel setuptools
pip install -e .[all,docs]

- name: Cache pybamm-requires nox environment for GNU/Linux
Expand All @@ -254,10 +254,10 @@ jobs:

- name: Install SuiteSparse and SUNDIALS on GNU/Linux
if: matrix.os == 'ubuntu-latest'
run: nox -s pybamm-requires
run: pipx run nox -s pybamm-requires

- name: Run integration tests for ${{ matrix.os }} with Python ${{ matrix.python-version }}
run: nox -s integration
run: pipx run nox -s integration

# Runs only on Ubuntu with Python 3.11. Skips IDAKLU module compilation
# for speedups, which is already tested in other jobs.
Expand Down Expand Up @@ -296,14 +296,14 @@ jobs:

- name: Install PyBaMM dependencies
run: |
pip install --upgrade pip wheel setuptools nox
pip install --upgrade pip wheel setuptools
pip install -e .[all,docs]

- name: Install docs dependencies and run doctests for GNU/Linux with Python 3.11
run: nox -s doctests
run: pipx run nox -s doctests

- name: Check if the documentation can be built for GNU/Linux with Python 3.11
run: nox -s docs
run: pipx run nox -s docs

# Runs only on Ubuntu with Python 3.11
run_example_tests:
Expand Down Expand Up @@ -341,7 +341,7 @@ jobs:

- name: Install PyBaMM dependencies
run: |
pip install --upgrade pip wheel setuptools nox
pip install --upgrade pip wheel setuptools
pip install -e .[all,docs]

- name: Cache pybamm-requires nox environment for GNU/Linux
Expand All @@ -358,10 +358,10 @@ jobs:
key: nox-pybamm-requires-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/install_KLU_Sundials.py') }}

- name: Install SuiteSparse and SUNDIALS on GNU/Linux
run: nox -s pybamm-requires
run: pipx run nox -s pybamm-requires

- name: Install dev dependencies and run example tests for GNU/Linux with Python 3.11
run: nox -s examples
run: pipx run nox -s examples

# Runs only on Ubuntu with Python 3.11
run_scripts_tests:
Expand Down Expand Up @@ -399,7 +399,7 @@ jobs:

- name: Install PyBaMM dependencies
run: |
pip install --upgrade pip wheel setuptools nox
pip install --upgrade pip wheel setuptools
pip install -e .[all,docs]

- name: Cache pybamm-requires nox environment for GNU/Linux
Expand All @@ -416,7 +416,7 @@ jobs:
key: nox-pybamm-requires-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/install_KLU_Sundials.py') }}

- name: Install SuiteSparse and SUNDIALS on GNU/Linux
run: nox -s pybamm-requires
run: pipx run nox -s pybamm-requires

- name: Install dev dependencies and run example scripts tests for GNU/Linux with Python 3.11
run: nox -s scripts
run: pipx run nox -s scripts
Loading