Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix esoh bug #3467

Merged
merged 1 commit into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ElectrodeSOHHalfCell(pybamm.BaseModel):

"""

def __init__(self, name="Electrode-specific SOH model"):
def __init__(self, name="ElectrodeSOH model"):
pybamm.citations.register("Mohtat2019")
super().__init__(name)
param = pybamm.LithiumIonParameters({"working electrode": "positive"})
Expand Down Expand Up @@ -140,7 +140,7 @@ def get_min_max_stoichiometries(
parameter_values : pybamm.ParameterValues
The parameter values to use in the calculation
"""
esoh_model = pybamm.lithium_ion.ElectrodeSOHHalfCell(options)
esoh_model = pybamm.lithium_ion.ElectrodeSOHHalfCell("ElectrodeSOH")
param = pybamm.LithiumIonParameters(options)
esoh_sim = pybamm.Simulation(esoh_model, parameter_values=parameter_values)
Q_w = parameter_values.evaluate(param.p.Q_init)
Expand Down
2 changes: 1 addition & 1 deletion pybamm/simulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ def solve(
)
if (
self.operating_mode == "without experiment"
or self._model.name == "ElectrodeSOH model"
or "ElectrodeSOH" in self._model.name
):
if t_eval is None:
raise pybamm.SolverError(
Expand Down
Loading