Refactor test_experiment_step_termination.py***

[abhicodes369]

(from unit test to pytest)

Description

converted a unit test case that uses the unit test to pytest. On the official website of pybamm I saw that they are considering migrating from unit test to pytest.

[agriyakhetarpal]

Thanks for starting this @abhicodes369. It looks good, but ideally we want to do this after #3617, so I will let this sit for a while until that is complete and pytest is added to the codebase. If you're interested in contributing, please feel free to discuss something over there since multiple people can be assigned to that issue 🙂

[agriyakhetarpal]

@abhicodes369, if you're interested, you can help drive #3857 to completion – or we can take this up again after it gets merged (should be about a week at most).

[abhicodes369]

I will look into it

[agriyakhetarpal]

Codacy raises a warning on assert statements despite the fact that it is the recommended way to write pytest-style tests and that these are test files. This can be disabled later, some insights here: fossasia/query-server#332

[agriyakhetarpal]

@allcontributors please add @abhicodes369 for tests

[allcontributors]

@agriyakhetarpal

I've put up a pull request to add @abhicodes369! 🎉

[agriyakhetarpal]

Thanks, @abhicodes369!

[abhicodes369]

thanks @agriyakhetarpal it really means a lot