Use delvewheel
to repair wheels on Windows, add MSVCRT DLLs
#4105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds what was missing to be done in #3783 – this should ensure that we get some extra non-UCRT DLLs in a
wheel.libs
folder inside the Windows wheel. This is not required but would be good to have because we use MSVC (Visual Studio 17 2022) as our compiler and not Clang/MinGW (which use UCRT) and therefore we should provide DLLs likeMSVCP140.dll
that have a tendency of not being present on many systems, in order to boost compatibility (this is mostly because of the absence of the MSVC Redistributable runtime components on quite a few systems). For most systems running Windows 10 and above, these files are generally present.Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: