Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4127 Set minimum JAX==0.4.27 #4129

Merged

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Jun 3, 2024

Description

Set minimum JAX version to 0.4.14 instead of 0.4

Fixes #4127

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@arjxn-py arjxn-py requested a review from a team as a code owner June 3, 2024 12:03
@agriyakhetarpal agriyakhetarpal self-requested a review June 3, 2024 12:34
Copy link
Contributor

@kratman kratman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing

pybamm/util.py Outdated Show resolved Hide resolved
@arjxn-py arjxn-py changed the title #4127 Set minimum JAX==0.4.16 #4127 Set minimum JAX==0.4.27 Jun 3, 2024
Copy link
Contributor

@kratman kratman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems fine to me. At minimum it should not break anything

@agriyakhetarpal agriyakhetarpal merged commit 640666a into pybamm-team:develop Jun 3, 2024
24 checks passed
@agriyakhetarpal agriyakhetarpal deleted the #4127-bump-jax-version branch June 3, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Minimum JAX version is 0.4.16
3 participants