Issue 4123 fix: SEI + Composite Integrations and lithium plating functions updated #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkec3
requested review from
brosaplanella,
DrSOKane,
rtimms,
valentinsulzer and
TomTranter
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4153 +/- ##
===========================================
+ Coverage 99.55% 99.58% +0.02%
===========================================
Files 288 288
Lines 21817 21789 -28
===========================================
- Hits 21720 21698 -22
+ Misses 97 91 -6 ☔ View full report in Codecov by Sentry. |
parkec3
changed the title
kratman
approved these changes
Jun 7, 2024
|
@allcontributors add @parkec3 for code |
|
I've put up a pull request to add @parkec3! 🎉 |
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this pull request
Aug 12, 2024
…tions updated (pybamm-team#4153) * pybamm-team#4123 fix * Updated plating.py with same bug fix from issue 4123 * Bug fix combined to one line * style: pre-commit fixes --------- Co-authored-by: Caitlin Parke <cat@Caitlins-MacBook-Pro.local> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated SEI and lithium plating submodels with domain options
Fixes #4123
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: