Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecm with diffusion #4254
Ecm with diffusion #4254
Changes from 11 commits
1bad235
4d97040
8397583
923a51f
dae8856
8476fb3
72e6cd6
47b1beb
23ab917
d4096e3
ac5c4af
e0b5e8b
c98f592
d60d16d
de0b00d
8fb974c
952698a
dad4f16
310651f
f2907d6
ee34c29
25d0a2d
5406cf7
5bb124f
83514a0
1ff0c8d
95d101f
fde2343
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 178 in pybamm/models/full_battery_models/equivalent_circuit/thevenin.py
Codecov / codecov/patch
pybamm/models/full_battery_models/equivalent_circuit/thevenin.py#L177-L178
Check warning on line 250 in pybamm/models/full_battery_models/equivalent_circuit/thevenin.py
Codecov / codecov/patch
pybamm/models/full_battery_models/equivalent_circuit/thevenin.py#L250
Check warning on line 253 in pybamm/models/full_battery_models/equivalent_circuit/thevenin.py
Codecov / codecov/patch
pybamm/models/full_battery_models/equivalent_circuit/thevenin.py#L253
Check warning on line 257 in pybamm/models/full_battery_models/equivalent_circuit/thevenin.py
Codecov / codecov/patch
pybamm/models/full_battery_models/equivalent_circuit/thevenin.py#L257
Check warning on line 260 in pybamm/models/full_battery_models/equivalent_circuit/thevenin.py
Codecov / codecov/patch
pybamm/models/full_battery_models/equivalent_circuit/thevenin.py#L260
Check warning on line 264 in pybamm/models/full_battery_models/equivalent_circuit/thevenin.py
Codecov / codecov/patch
pybamm/models/full_battery_models/equivalent_circuit/thevenin.py#L264
Check warning on line 268 in pybamm/models/full_battery_models/equivalent_circuit/thevenin.py
Codecov / codecov/patch
pybamm/models/full_battery_models/equivalent_circuit/thevenin.py#L268
Check warning on line 57 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L56-L57
Check warning on line 61 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L60-L61
Check warning on line 64 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L64
Check warning on line 68 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L68
Check warning on line 74 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L71-L74
Check warning on line 76 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L76
Check warning on line 83 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L83
Check warning on line 88 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L86-L88
Check warning on line 92 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L91-L92
Check warning on line 97 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L95-L97
Check warning on line 103 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L102-L103
Check warning on line 107 in pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py
Codecov / codecov/patch
pybamm/models/submodels/equivalent_circuit_elements/diffusion_element.py#L106-L107