Implement sodium-ion DFN

[brosaplanella]

Description

Implemented DFN for sodium-ion (same as lithium-ion but in a separate file to avoid conflicts). Implemented parameter value from Chayambuka et al (2022) (actual values and data taken from this COMSOL example).

When adding the CITATION I also modified many citation keys to be consistent with the format (FirstAuthorYear). Hence the many files changed.

Fixes #4397 (not an issue but a discussion)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (2ca16ac) to head (00c4412).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop    #4451    +/-   ##
=========================================
  Coverage    99.41%   99.42%            
=========================================
  Files          293      297     +4     
  Lines        22554    22685   +131     
=========================================
+ Hits         22423    22554   +131     
  Misses         131      131            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rtimms]

thanks @brosaplanella looks good, can you add a test in the basic model tests? sorry, realise this is draft and not finished

[brosaplanella]

Doctests are failing but I don't know why. @agriyakhetarpal can you help with this?

[DrSOKane]

Amazing work! The next step will be to implement the full DFN (with submodels) for sodium-ion, but this is a welcome and necessary first step.

[DrSOKane]

Amazing work! The next step will be to implement the full DFN (with submodels) for sodium-ion, but this is a welcome and necessary first step.

All you need to do is edit CHANGELOG and this should be ready to merge.

[kratman]

I can't vouch for the physics, but the code seems fine to me

[kratman]

Docs all failed, so I will check on that too

[kratman]

Docs failures are unreleated. I am looking into it, but will fix it in a different PR