-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#674 options notebook #677
Conversation
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 98.59% 98.71% +0.12%
==========================================
Files 169 170 +1
Lines 8450 9591 +1141
==========================================
+ Hits 8331 9468 +1137
- Misses 119 123 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, very clear. I would also add a reference to the using-submodels
notebook as another way of combining submodels more explicitly. Also make sure you add this to the example notebooks readme.
"\n", | ||
"# discretise model\n", | ||
"disc = pybamm.Discretisation(mesh, model.default_spatial_methods)\n", | ||
"disc.process_model(model)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end line with semicolon to suppress output
Description
Brief notebook showing how to pass options to a model (as an example, passes lumped thermal model to SPMe)
Fixes #674
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: