Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#547 remove sto times zero #724

Merged
merged 1 commit into from
Nov 13, 2019
Merged

#547 remove sto times zero #724

merged 1 commit into from
Nov 13, 2019

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Nov 12, 2019

Description

Remove sto*0 in the solid diffusion coefficients. This was fixed by something in an earlier PR which makes binary operators preserve shape during simplify (specifically addition of a scalar and a matrix)

Fixes #547

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #724 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #724   +/-   ##
======================================
  Coverage    98.1%   98.1%           
======================================
  Files         175     175           
  Lines        9196    9196           
======================================
  Hits         9022    9022           
  Misses        174     174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7254c...1466968. Read the comment docs.

@rtimms rtimms merged commit f06675b into master Nov 13, 2019
@rtimms rtimms deleted the issue-547-sto-times-zero branch November 13, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sto*0 from solid diffusivity functions
2 participants