Move install instructions to documentation #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlestang
changed the title
brosaplanella
approved these changes
May 11, 2020
There was a problem hiding this comment.
Thanks @tlestang , it looks great! Just a minor point, we should fix README.md as the links to the old installation instructions will be broken now.
Codecov Report
@@ Coverage Diff @@
## develop #988 +/- ##
========================================
Coverage 97.55% 97.55%
========================================
Files 233 233
Lines 12083 12083
========================================
Hits 11788 11788
Misses 295 295 Continue to review full report at Codecov.
|
valentinsulzer
approved these changes
May 11, 2020
Oh good point, fixing that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves installation instructions to documentation.
Fixes # (issue)
#987
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.