Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctests failing due to mismatch in unsorted output. #990

Merged
merged 2 commits into from
May 11, 2020
Merged

Doctests failing due to mismatch in unsorted output. #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e47def4
:bug: Doctets failing due to mismatch in unsorted output.
dalonsoa May 11, 2020
bdb11b9
Update CHANGELOG.
dalonsoa May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

## Bug fixes

- Fix doctests failing due to mismatch in unsorted output.([#990](https://github.com/pybamm-team/PyBaMM/pull/990))
- Added extra checks when creating a model, for clearer errors ([#971](https://github.com/pybamm-team/PyBaMM/pull/971))
- Fixed `Interpolant` ids to allow processing ([#962](https://github.com/pybamm-team/PyBaMM/pull/962))
- Fixed a bug in the initial conditions of the potential pair model ([#954](https://github.com/pybamm-team/PyBaMM/pull/954))
Expand Down
10 changes: 5 additions & 5 deletions pybamm/parameters_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,11 @@ def list_parameters(arguments=None):
>>> from pybamm.parameters_cli import list_parameters
>>> list_parameters(["lithium-ion", "anodes"])
Available package parameters:
* graphite_Ecker2015
* graphite_Chen2020
* graphite_mcmb2528_Marquis2019
* graphite_UMBL_Mohtat2020
* graphite_Ecker2015
* graphite_Kim2011
* graphite_UMBL_Mohtat2020
* graphite_mcmb2528_Marquis2019
Available local parameters:
"""
parser = argparse.ArgumentParser(
Expand All @@ -179,7 +179,7 @@ def list_parameters(arguments=None):
root, package_dirs, files = next(os.walk(package_dir))

print("Available package parameters:")
for dirname in package_dirs:
for dirname in sorted(package_dirs):
print(" * {}".format(dirname))

local_dir = os.path.join("input", "parameters", args.battery_type, args.component)
Expand All @@ -188,5 +188,5 @@ def list_parameters(arguments=None):
else:
local_dirs = []
print("Available local parameters:")
for dirname in local_dirs:
for dirname in sorted(local_dirs):
print(" * {}".format(dirname))