Skip to content

Commit

Permalink
feat: integrate eis predictions into PyBOP model building, switch lin…
Browse files Browse the repository at this point in the history
…ear solve to spsolve, add support for geometric parameters
  • Loading branch information
BradyPlanden committed Jul 11, 2024
1 parent 080f183 commit e754d7d
Show file tree
Hide file tree
Showing 3 changed files with 58 additions and 913 deletions.
14 changes: 8 additions & 6 deletions examples/scripts/eis_fitting.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
# Fitting parameters
parameters = pybop.Parameters(
pybop.Parameter(
"Negative electrode active material volume fraction",
prior=pybop.Gaussian(0.6, 0.05),
"Positive electrode double-layer capacity [F.m-2]",
prior=pybop.Gaussian(0.1, 0.05),
),
pybop.Parameter(
"Positive electrode active material volume fraction",
prior=pybop.Gaussian(0.48, 0.05),
"Negative electrode thickness [m]",
prior=pybop.Gaussian(40e-6, 0.0),
),
)

Expand All @@ -39,8 +39,10 @@
signal = ["Impedance"]
# Generate problem, cost function, and optimisation class
problem = pybop.EISProblem(model, parameters, dataset, signal=signal)
prediction = problem.evaluate(np.array([0.75, 0.665]))
fig = px.scatter(x=prediction["Impedance"].real, y=-prediction["Impedance"].imag)
prediction_1 = problem.evaluate(np.array([1.0, 60e-6]))
prediction_2 = problem.evaluate(np.array([10.0, 40e-6]))
fig = px.scatter(x=prediction_1["Impedance"].real, y=-prediction_1["Impedance"].imag)
fig.add_scatter(x=prediction_2["Impedance"].real, y=-prediction_2["Impedance"].imag)
fig.show()
# cost = pybop.SumSquaredError(problem)
# optim = pybop.CMAES(cost, max_iterations=100)
Expand Down
Loading

0 comments on commit e754d7d

Please sign in to comment.