Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Pints' optimisers #117

Merged
merged 8 commits into from
Nov 23, 2023
Merged

Adds Pints' optimisers #117

merged 8 commits into from
Nov 23, 2023

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Nov 22, 2023

Closes #116. Adds the remaining Pints' optimiser methods, and updates examples.

I've left _nelder-mead.py and _cmaes_bare.py out of this PR, as we have access to the former via SciPy and I don't believe we need two CMAES methods for the latter.

@BradyPlanden BradyPlanden linked an issue Nov 22, 2023 that may be closed by this pull request
9 tasks
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83ec94b) 93.75% compared to head (eee379d) 90.57%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #117      +/-   ##
===========================================
- Coverage    93.75%   90.57%   -3.19%     
===========================================
  Files           29       18      -11     
  Lines          993      647     -346     
===========================================
- Hits           931      586     -345     
+ Misses          62       61       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden
Copy link
Member Author

This is now ready for review. In this PR, I've forked one of the example scripts and updated it to include the different optimiser methods we have. We may want to consider moving these to a separate directory, such as examples/scripts/optimisers.

Unfortunately, the tests have regressed, but this is to be expected as I have removed the `tests/' directory from the CodeCov bot. The patch percentage is good for the merge, but we will need to add more coverage in the future.

Copy link
Member

@NicolaCourtier NicolaCourtier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on adding the optimisers, thanks @BradyPlanden !

@BradyPlanden BradyPlanden merged commit 5225cfc into develop Nov 23, 2023
18 of 19 checks passed
@BradyPlanden BradyPlanden deleted the 116-add-pints-optimisers branch November 23, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pints' optimisers
2 participants