Removes NLOpt Methods #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #172 +/- ##
===========================================
- Coverage 94.26% 94.07% -0.20%
===========================================
Files 37 34 -3
Lines 1377 1299 -78
===========================================
- Hits 1298 1222 -76
+ Misses 79 77 -2 ☔ View full report in Codecov by Sentry. |
NicolaCourtier
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
A useful update - thanks @BradyPlanden! I updated test_standalone.py from the develop branch as well to run with SciPyDifferentialEvolution instead of NLopt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes NLOpt from PyBOP and closes #63. With the additions of the Pints and SciPy methods, NLOpt is being removed from future releases due to the build challenges for the apple m-series platform.
Future implementations of the NLOpt methods should be considered which can be found here.