-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calculation of cyclable lithium capacity #349
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #349 +/- ##
===========================================
+ Coverage 97.29% 97.57% +0.27%
===========================================
Files 46 42 -4
Lines 2808 2429 -379
===========================================
- Hits 2732 2370 -362
+ Misses 76 59 -17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NicolaCourtier - this is looking good. It would be nice to integrate this functionality further into the codebase so the end-user API is agnostic to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for these additions!
Description
Add a new function to compute equivalent initial lithium concentrations in the positive electrode prior to formation. Use this function to update the calculation of the cyclale lithium content in the
spme_max_energy
example script.Issue reference
Fixes #339
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.