Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v23.4.1 #373

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Merge v23.4.1 #373

merged 5 commits into from
Jun 18, 2024

Conversation

BradyPlanden
Copy link
Member

Description

Merges v24.3.1 into develop.

Issue reference

Fixes # (issue-number)

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (c2f4ec4) to head (025d60f).
Report is 715 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #373      +/-   ##
===========================================
+ Coverage    97.27%   97.39%   +0.12%     
===========================================
  Files           42       42              
  Lines         2419     2418       -1     
===========================================
+ Hits          2353     2355       +2     
+ Misses          66       63       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden merged commit 5e1c7f8 into develop Jun 18, 2024
29 checks passed
@BradyPlanden BradyPlanden deleted the v24.3.1_into_develop branch June 18, 2024 12:25
@agriyakhetarpal
Copy link
Member

Note: I noticed that the release workflow failed in https://github.com/pybop-team/PyBOP/actions/runs/9564192313 because we haven't allowed the softprops action to run in this repository – the PyPI publishing job did pass, though 😬

@BradyPlanden
Copy link
Member Author

Fixed now! Let's see how it does on the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants