Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new PKCS12 test vectors #6383

Merged
merged 3 commits into from
Oct 6, 2021

Conversation

felixfontein
Copy link
Contributor

Part of #6348; see #6348 (comment).

CC @reaperhulk

@reaperhulk
Copy link
Member

One big question here, why use a DSA cert? Nobody uses those and some day we may want to deprecate support, which these vectors will make more of a challenge 😄

@felixfontein
Copy link
Contributor Author

I basically used the same certs that the other PKCS12 tests were using, and cert2 happens to use a DSA key. Should I replace them by something else (like x509/cryptography.io.pem)?

@reaperhulk
Copy link
Member

Yeah please do, sorry about that 😢

@felixfontein
Copy link
Contributor Author

I'm using the following script to create the vectors: https://gist.github.com/felixfontein/f750763fd5773fbf0ab22af87239aab0 It's based on an earlier version of #6348 which had serialization code.

(Unfortunately it's not idempotent, I guess that is because PKCS12 serialization includes some randomness.)

@reaperhulk reaperhulk merged commit 667e7a5 into pyca:main Oct 6, 2021
@felixfontein felixfontein deleted the pkcs12-new-test-vectors branch October 6, 2021 04:49
@felixfontein
Copy link
Contributor Author

@reaperhulk thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants