Modified save argument of plot_model() #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhanuteja2001
changed the title
bhanuteja2001
changed the title
|
Hey @bhanuteja2001 thank you for doing this. Could we do something like this instead for all plots? if save:
if not isinstance(save, bool):
plot_filename = os.path.join(save, plot_filename)
logger.info(f"Saving '{plot_filename}'")
fig.write_html(plot_filename)This will be much easier to maintain. Thanks! Let me know if you have any questions. |
|
@Yard1 sure let's do it this way |
|
@Yard1 I have made the changes. |
Yard1
requested changes
Sep 3, 2021
pycaret/internal/tabular.py
Outdated
| @@ -6918,8 +6934,10 @@ def tree(): | |||
| display.move_progress() | |||
| display.clear_output() | |||
| if save: | |||
| logger.info(f"Saving '{plot_name}.png' in current active directory") | |||
| plt.savefig(f"{plot_name}.png", bbox_inches="tight") | |||
| if not isinstance(save, bool): | |||
pycaret/internal/tabular.py
Outdated
| @@ -6963,8 +6981,10 @@ def calibration(): | |||
| display.move_progress() | |||
| display.clear_output() | |||
| if save: | |||
| logger.info(f"Saving '{plot_name}.png' in current active directory") | |||
| plt.savefig(f"{plot_name}.png", bbox_inches="tight") | |||
| if not isinstance(save, bool): | |||
pycaret/internal/tabular.py
Outdated
| @@ -7607,7 +7631,10 @@ def summary(show: bool = True): | |||
| shap_plot = shap.summary_plot(shap_values, test_X, show=show, **kwargs) | |||
|
|
|||
| if save: | |||
| plt.savefig(f"SHAP {plot}.png", bbox_inches="tight") | |||
| if save == True: | |||
pycaret/internal/tabular.py
Outdated
| @@ -7640,7 +7667,10 @@ def correlation(show: bool = True): | |||
| logger.info("model type detected: type 2") | |||
| shap.dependence_plot(dependence, shap_values, test_X, show=show, **kwargs) | |||
| if save: | |||
| plt.savefig(f"SHAP {plot}.png", bbox_inches="tight") | |||
| if save == True: | |||
|
@Yard1 please check now. |
Yard1
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enchancement #1288
Describe the changes you've made
Modified the save argument of plot_model to save the figure at the destination mentioned by the user. Instead of just saving the figure in the current directory.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested with the confusion matrix plot.
Describe if there is any unusual behaviour of your code(Write
NAif there isn't)NA
Checklist:
Screenshots