Modernize packaging. #599
Modernize packaging. #599
Conversation
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
==========================================
- Coverage 92.16% 7.75% -84.42%
==========================================
Files 20 19 -1
Lines 3305 3277 -28
==========================================
- Hits 3046 254 -2792
- Misses 259 3023 +2764 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from ._coo.common import ( | ||
| asCOO, | ||
| ) |
Check notice
Code scanning / CodeQL
Cyclic import Note
| normalize_axis, | ||
| equivalent, | ||
| check_zero_fill_value, | ||
| from sparse._common import dot, matmul |
Check notice
Code scanning / CodeQL
Cyclic import Note
There was a problem hiding this comment.
Minor suggestion: you can drop flake8 entirely as ruff provides those on its own.
I'm having trouble figuring out if the universal bdist_wheel setting can be moved to pyproject.toml -- it feels like that should be supported, and is a bug in setuptools if not. But if it works then setup.cfg can be removed entirely.
It's possible a universal wheel is the default now? Haven't tested this though
|
Thanks for the review! Yeah, I was considering that as well. |
I'm not sure I would call it a review in that I barely looked at most of the change 😂 but I will take a more thorough look later and test things out. |
|
It looks like you already removed flake8, actually. Just a few references to it in the contributing docs. As an experiment I removed edit: I guess this isn't a true "universal" wheel that's compatible with Python 2, but I suspect that this isn't really supported anymore because Python 2 was sunset at the beginning of 2020. I don't think there's much value in building for it, certainly it's not worth supporting officially. |
No description provided.