-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Establish pydata_backend
#646
Conversation
Test Results5 899 tests +2 5 865 ✅ - 1 3m 18s ⏱️ -1s Results for commit 4c309c7. ± Comparison against base commit 92e8078. This pull request removes 5897 and adds 5899 tests. Note that renamed tests count towards both.
This pull request removes 31 skipped tests and adds 34 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work here, @mtsokol! A couple of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes.
We also need a rebase. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Quick question: since |
Sure! I think they can be prepended with an underscore. There will always be backend-specific members, like GCXS only present in |
Replaces #645
Hi @hameerabbasi,
Including the new backend in
pydata/sparse
ended up a bit convoluted, therefore I decided to break this task into smaller steps.Here's the first step which moves existing implementation to
sparse/pydata_backend
directory with tests and adds context manager that tracks backend contextvar. The test suite has a lot of pydata specific calls so it will be a separate effort to make tests common for both backends.I applied all your comments from #645 here.
The next PR will run some stub tests with finch to see that it can be installed and run in CI.