Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

madx pattern for doros BPMs #445

Merged
merged 9 commits into from
Sep 2, 2024
Merged

madx pattern for doros BPMs #445

merged 9 commits into from
Sep 2, 2024

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Aug 22, 2024

  • Adds DOROS BPMs to twiss.dat
  • Removes Pandas future warnings, as far as I saw them:
    • phase.py: FutureWarning: The behavior of DataFrame concatenation with empty or all-NA entries is deprecated.
    • beta_from_phase.py and kick.py: FutureWarning: Setting an item of incompatible dtype is deprecated and will raise in a future error of pandas.

@JoschD JoschD added Type: Release Issue preparing for a release. Bugfix labels Aug 22, 2024
@JoschD JoschD self-assigned this Aug 22, 2024
@JoschD JoschD added the Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. label Aug 22, 2024
@JoschD JoschD marked this pull request as ready for review August 22, 2024 19:07
Copy link

codeclimate bot commented Sep 2, 2024

Code Climate has analyzed commit e739f4b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 88.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.0% (0.0% change).

View more on Code Climate.

@JoschD JoschD merged commit 04455a1 into master Sep 2, 2024
37 checks passed
@JoschD JoschD deleted the add_doros_twiss_dat branch September 2, 2024 10:42
@pylhctokens pylhctokens added the Type: Bug Something isn't working as it should. label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as it should. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. Type: Release Issue preparing for a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants