Emit assignment-from-no-return for builtin methods like dict.update() #8817
Conversation
This comment has been minimized.
This comment has been minimized.
| (Calls to ``list.sort()`` now raise ``assignment-from-no-return`` | ||
| rather than ``assignment-from-none`` for consistency.) |
There was a problem hiding this comment.
You added that 2 days ago in #8809, right ? We probably don't need to advertise the change as it's unreleased.
There was a problem hiding this comment.
| (Calls to ``list.sort()`` now raise ``assignment-from-no-return`` | |
| rather than ``assignment-from-none`` for consistency.) |
There was a problem hiding this comment.
Actually, it's changed in this PR. In #8809 I added all the other methods besides list.sort() to the existing assignment-from-none, which is only correct if we were going to merge the messages. :-)
There was a problem hiding this comment.
list.sort() only was special-cased in #5738
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8817 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 173 173
Lines 18508 18508
=======================================
Hits 17749 17749
Misses 759 759
|
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 0c0d952 |
Type of Changes
Description
Follow-up to 32effc5.
Since we won't be merging
assignment-from-no-returnwithassignment-from-none, we should emit the correct message for builtins likelist.sort()anddict.update(). Onlylist.sort()is a behavior change from stable versions.Closes #8810