Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for older python versions. #61

Closed
wants to merge 12 commits into from
Closed

Conversation

BenediktBurger
Copy link
Member

Just to test old python versions (Py 3.7, Py 3.8)

@BenediktBurger BenediktBurger added the enhancement New feature or request label Feb 23, 2024
@BenediktBurger BenediktBurger marked this pull request as draft February 23, 2024 12:18
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 91.76030% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 87.53%. Comparing base (4cc7cca) to head (08c198c).

Files Patch % Lines
pyleco/json_utils/rpc_server_definition.py 84.81% 7 Missing and 5 partials ⚠️
pyleco/json_utils/errors.py 88.88% 4 Missing ⚠️
pyleco/actors/actor.py 62.50% 2 Missing and 1 partial ⚠️
pyleco/directors/transparent_director.py 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           feature/legacy      #61      +/-   ##
==================================================
+ Coverage           87.28%   87.53%   +0.25%     
==================================================
  Files                  33       36       +3     
  Lines                2626     2856     +230     
  Branches              314      345      +31     
==================================================
+ Hits                 2292     2500     +208     
- Misses                280      295      +15     
- Partials               54       61       +7     
Flag Coverage Δ
unittests 87.53% <91.76%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenediktBurger
Copy link
Member Author

Python<3.9 requires typing.List instead of list.
On the other hand, pydantic (a dependency of openrpc) requires list and not typing.List to annotate methods available via RPC.

@BenediktBurger
Copy link
Member Author

We have to rename cls argument to device class.
(major change).

For 3.7, setup tools makes problems

@BenediktBurger BenediktBurger changed the title Remove jsonrpc dependency. Test for older python versions. Feb 26, 2024
@BenediktBurger BenediktBurger force-pushed the test-legacy branch 2 times, most recently from 15e90c7 to 5c48bea Compare February 26, 2024 14:44
@BenediktBurger
Copy link
Member Author

typing.Protocol is for Python>=3.8, so 3.7 is not viable
Other 3.8 feature: walrus operator (":=")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant