Address 3820 #3825
Merged
Address 3820 #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-smith-artifex-com
requested changes
Aug 30, 2024
When creating link destinations from a PDF's names dictionary as created by `.resolve_names()`, we incorrectly use strings with %-escaped spaces (and other characters) as keys to find dictionary values. This change revert %-escaped names to the original. E.g. every "%20" sub-string is converted to a space, etc.
JorjMcKie
force-pushed
the
address-3820
branch
from
cb883b9
to
b8e5b55
Compare
julian-smith-artifex-com
approved these changes
Aug 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating link destinations from a PDF's names dictionary as created by
.resolve_names(), we incorrectly use strings with %-escaped spaces (and other characters) as keys to find dictionary values. This change revert %-escaped names to the original. E.g. every "%20" sub-string is converted to a space, etc.