Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: un-pin virtualenv update #1830

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented May 18, 2024

virtualenv has been pinned to 20.21.1 in order to be able to create python 3.6 venvs.

This commit allows to pin virtualenv for given versions of pythons which in turns re-allows updates as a default.

@mayeut mayeut marked this pull request as draft May 18, 2024 16:32
@mayeut
Copy link
Member Author

mayeut commented May 18, 2024

converting to draft while I debug Windows builds.

virtualenv has been pinned to 20.21.1 in order to be
able to create python 3.6 venvs.

This commit allows to pin virtualenv for given versions
of pythons which in turns re-allows updates as a default.
@@ -111,7 +111,6 @@ def test_dependency_constraints_file(tmp_path, build_frontend_env):
"""
pip=={pip}
delocate=={delocate}
importlib-metadata<3,>=0.12; python_version < "3.8"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests on windows came from this pin.
I'm not sure exactly why since I can't really debug on Windows.
All I can say is that it was causing some backtracking in the pip resolver in order to install an old version of virtualenv (2.16.2).

@mayeut mayeut marked this pull request as ready for review May 19, 2024 06:14
@henryiii henryiii merged commit d1a4c9c into pypa:main May 20, 2024
20 checks passed
@mayeut mayeut deleted the virtualenv-update branch May 20, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants