Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

An obvious typo. #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mindw
Copy link

@mindw mindw commented Jul 30, 2016

Running the test without the fix results in:

>python p508.py
Traceback (most recent call last):
  File "p508.py", line 163, in <module>
    parsed = compiled(test).specification()
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\parsley.py", line 85, in invokeRule
    ret, err = self._grammar.apply(name, *args)
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 462, in apply
    val, err = self._apply(r, ruleName, args)
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1079, in rule_specification
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 598, in _or
    ret, err = f()
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1071, in _G_or_376
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1006, in rule_url_req
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 859, in rule_name
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 850, in rule_identifier
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 676, in consumedby
    _, e = expr()
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 847, in _G_consumedby_294
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 554, in many
    v, _ = fn()
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 844, in _G_many_296
AttributeError: 'Grammar' object has no attribute 'rule_identifier_end'

This change is Reviewable

Running the test without the fix results in:
```
>python p508.py
Traceback (most recent call last):
  File "p508.py", line 163, in <module>
    parsed = compiled(test).specification()
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\parsley.py", line 85, in invokeRule
    ret, err = self._grammar.apply(name, *args)
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 462, in apply
    val, err = self._apply(r, ruleName, args)
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1079, in rule_specification
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 598, in _or
    ret, err = f()
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1071, in _G_or_376
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1006, in rule_url_req
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 859, in rule_name
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 850, in rule_identifier
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 676, in consumedby
    _, e = expr()
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 847, in _G_consumedby_294
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 554, in many
    v, _ = fn()
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 844, in _G_many_296
AttributeError: 'Grammar' object has no attribute 'rule_identifier_end'
```
@doismellburning
Copy link

I have used this commit in python/peps#851. That repository now seems to be the canonical home of this PEP - does a copy still belong here? @dstufft ...?

@ncoghlan
Copy link
Member

This repo isn't used for anything any more, since the main PEPs repo migrated to GitHub.

I've filed #71 to discuss actually archiving it, to make it clear there's no need for anyone to keep it up to date.

@doismellburning
Copy link

Great, thanks

@Badgers69
Copy link

pep-0459-standard-metadata-extensions.rst

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants