Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch python_full_version unconditionally #825

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Aug 16, 2024

Closes #678 . Reprise of #802.

  • Extract a method for repairing the python_full_version.
  • Repair the version even if passed in.
  • Update test to reflect the new expectation.

@jaraco jaraco force-pushed the bugfix/678-python-full-version-untagged branch 2 times, most recently from 46a2d24 to cc7c168 Compare August 16, 2024 20:11
@jaraco jaraco requested a review from sbidoul August 16, 2024 20:13
@jaraco jaraco force-pushed the bugfix/678-python-full-version-untagged branch from cc7c168 to 540fe8d Compare August 16, 2024 20:14
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on this. In #802 I did the smallest possible change to unblock pip.

In the end the root cause applies to all environment markers (#774).

@jaraco
Copy link
Member Author

jaraco commented Aug 16, 2024

In the end the root cause applies to all environment markers (#774).

Indeed, this change won't affect those failures, because they're related to platform_release. At least with python_full_version, there's a pretty constrained space of potential versions (whatever CPython or its variants produce).

I'm somewhat disinterested in solving the larger issue, given that I was happy with distutils' lenient version objects.

@brettcannon brettcannon merged commit c385b58 into pypa:main Aug 27, 2024
32 checks passed
@jaraco jaraco deleted the bugfix/678-python-full-version-untagged branch August 27, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-tagged Python builds use non-PEP 440 versions
3 participants