Skip to content

Commit

Permalink
Move resolver test helpers into test file
Browse files Browse the repository at this point in the history
They probably don't need to be global, and this fixes complaints from
Flake8 for unused imports.
  • Loading branch information
uranusjr committed Feb 28, 2020
1 parent d0ad73a commit e7e3cdc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
from tests.lib import DATA_DIR, SRC_DIR, TestData
from tests.lib.certs import make_tls_cert, serialize_cert, serialize_key
from tests.lib.path import Path
from tests.lib.pip_api_helpers import finder, preparer
from tests.lib.scripttest import PipTestEnvironment
from tests.lib.server import make_mock_server, server_running
from tests.lib.venv import VirtualEnvironment
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from pip._internal.commands.install import InstallCommand
from pip._internal.index.collector import LinkCollector
from pip._internal.index.package_finder import PackageFinder
from pip._internal.models.index import PyPI
# from pip._internal.models.index import PyPI
from pip._internal.models.search_scope import SearchScope
from pip._internal.models.selection_prefs import SelectionPreferences
from pip._internal.network.session import PipSession
Expand Down

3 comments on commit e7e3cdc

@pfmoore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I couldn't see a good way to shut flake8 up over the fixtures. We can revisit the question if it turns out that these are needed in more than one place.

@uranusjr
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# noqa 😛 (I put them in a directory instead in a later commit.)

@pfmoore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there's always that 😉

Please sign in to comment.