Simplify RequirementPreparer._downloaded data structure #10346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdufresne
changed the title
The original type was `Dict[str, Tuple[str, str]]`. The 2nd element of the tuple goes unused so map to a single str instead.
|
Requesting reviews from people involved in this as a part of #8737. @McSinyx @chrahunt @pradyunsg |
McSinyx
approved these changes
Aug 10, 2021
pradyunsg
approved these changes
Aug 12, 2021
|
Thanks @jdufresne! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original type was
Dict[str, Tuple[str, str]]. The 2nd element ofthe tuple goes unused so map to a single str instead.