Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move __pip-runner__ script into a module #11262

Merged
merged 3 commits into from
Jul 16, 2022
Merged

Move __pip-runner__ script into a module #11262

merged 3 commits into from
Jul 16, 2022

Commits on Jul 15, 2022

  1. Move __pip-runner__ script into a module 

    This makes it possible to eliminate the need for writing a copy of this
script in a temporary directory for each isolated build environment.
    @pradyunsg
    pradyunsg committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    5f2a858 View commit details
    Browse the repository at this point in the history

  2. Rework the pip runner to use PathFinder 

    This makes it possible to only "replace" `pip` and have the submodules
get correctly located by the regular importlib machinery. This also
asserts that it was able to locate the module, ensuring that failure to
locate the module results in an exception.
    @pradyunsg
    pradyunsg committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    00e5adf View commit details
    Browse the repository at this point in the history

  3. Add a test that the runner script works in environments without pip 

    This ensures that the runner script can be used in environments where
pip is not installed.
    @pradyunsg
    pradyunsg committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    470b217 View commit details
    Browse the repository at this point in the history