Fix Tests by depending on testpypi #4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
C: automation
|
And I'm gonna rush to class now. :P |
|
Awesome! This fixed the tests. Thanks @benoit-pierre for figuring out why
the tests failed. :)
/ping @dstufft?
…On Tue, 12 Sep 2017 at 15:45 Pradyun Gedam ***@***.***> wrote:
And I'm gonna rush to class now. :P
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4719 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADH7SbhVFlHa8z5mvgZOQUjV9HTQ9gsOks5shlm0gaJpZM4PUamB>
.
|
|
Prevents #4557 from being tested. |
|
Could you cherry-pick that commit and work with that? Just add a note to
the first post about it. :)
…On Thu, Sep 14, 2017, 16:39 anatoly techtonik ***@***.***> wrote:
Prevents #4457 <#4457> from being
tested.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#4719 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADH7SXv3A2tVobU5iTy0mwYXhhREvtWCks5siQlqgaJpZM4PUamB>
.
|
|
Whoever comes around to merging this, please don't rebase or squash merge this PR; a normal merge with merge commit would be nice to have. :) |
|
Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4715.