Prevent infinite recursion with pip wheel with $TMPDIR in $PWD #7873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmoore
reviewed
Mar 19, 2020
During a build of extension module within `pip wheel` the source directory is recursively copied in a temporary directory. See pypa#7555 When the temporary directory is inside the source directory (for example by setting `TMPDIR=$PWD/tmp`) this caused an infinite recursion that ended in: [Errno 36] File name too long We prevent that buy never copying the target to the target in _copy_source_tree. Fixes pypa#7872
pradyunsg
reviewed
Mar 19, 2020
pradyunsg
approved these changes
Mar 19, 2020
hroncok
commented
Mar 19, 2020
|
I've decided to skip the test on Windows, because the empty source doesn't work there. Let me know if I shall write an actual stub extension instead, but I'd rather avoid that. |
|
Is there anything else I need to change? |
xavfernandez
approved these changes
Mar 27, 2020
|
@hroncok Nope; just needed one of us to click the green button. :) |
|
Thanks! 🙇 |
|
Thanks, I'm watching #7555 closely. Setting TMPDIR to pwd is just a temporary hack. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a build of extension module within
pip wheelthe source directory isrecursively copied in a temporary directory.
See #7555
When the temporary directory is inside the source directory
(for example by setting
TMPDIR=$PWD/tmp) this caused an infinite recursionthat ended in:
We prevent that buy never copying the target to the target in _copy_source_tree.
Fixes #7872