Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor new resolver to remove state from factory #8195

Closed
wants to merge 7 commits into from
Closed

Refactor new resolver to remove state from factory #8195

wants to merge 7 commits into from

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented May 5, 2020

Followup to #8170

This PR moves all state (constraints and root project names) off the factory and into the provider.

It's based on #8170, so that PR needs to be merged before this one.

@pfmoore pfmoore requested review from uranusjr and pradyunsg May 5, 2020 18:13
@pfmoore pfmoore added the skip news Does not need a NEWS file entry (eg: trivial changes) label May 5, 2020
@uranusjr uranusjr mentioned this pull request May 5, 2020
Merged
@pradyunsg
Copy link
Member

This was part of #8170 IIUC. Can we close this?

@pfmoore
Copy link
Member Author

pfmoore commented May 7, 2020

Not yet, please. It's built on top of #8170. I'm still looking at whether it's easier to rebase it on master now that's merged, or rewrite it from scratch. I'll close this if I go with a rewrite.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 7, 2020
@uranusjr
Copy link
Member

I believe #8234 supercedes this?

@pfmoore
Copy link
Member Author

pfmoore commented May 19, 2020

It does, yes. I thought I'd tidied stuff up but I missed this one - thanks!

@pfmoore pfmoore closed this May 19, 2020
@pfmoore pfmoore deleted the nr_refactor_factory branch May 19, 2020 10:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr left review comments

@pradyunsg pradyunsg Awaiting requested review from pradyunsg

Assignees
No one assigned
Labels
needs rebase or merge PR has conflicts with current master skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pfmoore @pradyunsg @BrownTruck @uranusjr