Skip to content

Commit

Permalink
Fix pep517.check to pass build-system requires
Browse files Browse the repository at this point in the history
Closes gh-14
  • Loading branch information
takluyver committed Dec 12, 2018
1 parent 450a96a commit c47dd1c
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions pep517/check.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@

log = logging.getLogger(__name__)

def check_build_sdist(hooks):
def check_build_sdist(hooks, build_sys_requires):
with BuildEnvironment() as env:
try:
env.pip_install(hooks.build_sys_requires)
env.pip_install(build_sys_requires)
log.info('Installed static build dependencies')
except CalledProcessError:
log.error('Failed to install static build dependencies')
Expand Down Expand Up @@ -73,10 +73,10 @@ def check_build_sdist(hooks):

return True

def check_build_wheel(hooks):
def check_build_wheel(hooks, build_sys_requires):
with BuildEnvironment() as env:
try:
env.pip_install(hooks.build_sys_requires)
env.pip_install(build_sys_requires)
log.info('Installed static build dependencies')
except CalledProcessError:
log.error('Failed to install static build dependencies')
Expand Down Expand Up @@ -151,8 +151,8 @@ def check(source_dir):

hooks = Pep517HookCaller(source_dir, backend)

sdist_ok = check_build_sdist(hooks)
wheel_ok = check_build_wheel(hooks)
sdist_ok = check_build_sdist(hooks, requires)
wheel_ok = check_build_wheel(hooks, requires)

if not sdist_ok:
log.warning('Sdist checks failed; scroll up to see')
Expand Down

0 comments on commit c47dd1c

Please sign in to comment.