Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make minimal_egg_info string in bootstrap.py unicode #1063

Closed
wants to merge 1 commit into from

Commits on Jun 14, 2017

  1. minimal_egg_info string in bootstrap.py needs to be unicode.

    I believe this is likely to be safe in general, but have only tested with 2.7 on on OS X.
    
    Without this change, I am seeing error:
    
    ```
    $ git clone git@github.com:pypa/setuptools
    Cloning into 'setuptools'...
    remote: Counting objects: 24321, done.
    remote: Compressing objects: 100% (23/23), done.
    remote: Total 24321 (delta 11), reused 20 (delta 7), pack-reused 24291
    Receiving objects: 100% (24321/24321), 28.77 MiB | 7.38 MiB/s, done.
    Resolving deltas: 100% (8669/8669), done.
    $ cd setuptools
    $ git rev-parse HEAD
    995d309
    $ python bootstrap.py
    adding minimal entry_points
    Traceback (most recent call last):
      File "bootstrap.py", line 63, in <module>
        __name__ == '__main__' and main()
      File "bootstrap.py", line 59, in main
        ensure_egg_info()
      File "bootstrap.py", line 37, in ensure_egg_info
        build_egg_info()
      File "bootstrap.py", line 47, in build_egg_info
        ep.write(minimal_egg_info)
    TypeError: must be unicode, not str
    ```
    mattgiles committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    4445043 View commit details
    Browse the repository at this point in the history