-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix environment markers handling #1081
Merged
jaraco
merged 1 commit into
pypa:master
from
benoit-pierre:fix_environment_markers_handling
Jul 14, 2017
Merged
Fix environment markers handling #1081
jaraco
merged 1 commit into
pypa:master
from
benoit-pierre:fix_environment_markers_handling
Jul 14, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2017
benoit-pierre
force-pushed
the
fix_environment_markers_handling
branch
from
July 13, 2017 19:27
e3692a5
to
050808d
Compare
Rebased on master. |
jaraco
added a commit
that referenced
this pull request
Jul 14, 2017
suutari-ai
pushed a commit
to suutari/prequ
that referenced
this pull request
Aug 2, 2017
If the wheel is generated with older setuptools it will have incorrect requirements for Python 3, since some of the requirements use environment markers and there was a problem with those in older versions of the setuptools. See pypa/setuptools#1081 and pypa/setuptools#1108 for details.
stephenfin
added a commit
to stephenfin/setuptools
that referenced
this pull request
Mar 26, 2018
This ensures we don't unknowingly change the behavior of this again. Signed-off-by: Stephen Finucane <stephen@that.guru> Fixes: pypa#1307
pganssle
added a commit
that referenced
this pull request
Mar 26, 2018
tests: Add regression test for #1081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the documentation now points to using environment markers with
install_requires
for declaring platform dependencies, this result in invalid wheels because those are stripped from the final requirements in the embedded metadata.E.g, using something like this:
result in
foo.egg-info/requires.txt
containing:instead of:
which yields:
This PR automatically move requirements in
install_requires
that use environment markers toextras_require
so the egg info is valid and the generated wheels work as expected.Additionally, I added a check to error out if an
extras_require
requirement is itself using an environment marker, as it's not supported.Note: first commit is a fix for the same issue as #1063, so I'll rebase once this is merged.