Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test tags on multiple lines now handled correctly #706

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jsa34
Copy link
Contributor

@jsa34 jsa34 commented Sep 26, 2024

Resolves #194

youtux
youtux previously approved these changes Sep 26, 2024
Copy link
Contributor

@youtux youtux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@youtux
Copy link
Contributor

youtux commented Sep 26, 2024

test is failing with py3.11-pytest6.2-coverage, can you double check?

@jsa34
Copy link
Contributor Author

jsa34 commented Sep 26, 2024

It's my test syntax with pytest 6. What's the minimum supported version of pytest we support? It doesn't seem as clear cut as python's support cycle.

@youtux
Copy link
Contributor

youtux commented Sep 26, 2024

we can drop pytest 6.2 compatibility, as it's quite old (released in 2021).

We should indeed declare the pytest requirement in pyproject.yaml

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (20faa0c) to head (88874a9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   95.27%   95.28%   +0.01%     
==========================================
  Files          53       53              
  Lines        2010     2016       +6     
  Branches      228      228              
==========================================
+ Hits         1915     1921       +6     
  Misses         58       58              
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple lines with tags override previous lines
2 participants