consider catch2's FAIL()

[sshane]

I believe FAIL_CHECK also produces a Failure tag

https://github.com/catchorg/Catch2/blob/fa43b77429ba76c462b1898d6cd2f2d7a9416b14/docs/logging.md?plain=1#L119-L125

This wasn't being marked as a failure with pytest, now it is:

code:

void checkWidgetTrWrap(MainWindow &w) {
  for (auto widget : w.findChildren<T>()) {
  const QString text = widget->text();
    bool isNumber = RE_NUM.exactMatch(text);
    bool wrapped = text.contains(TEST_TEXT);
    QString parentWidgets = getParentWidgets(widget).join("->");

    if (!text.isEmpty() && !isNumber && !wrapped) {
      FAIL(("\"" + text + "\" must be wrapped. Parent widgets: " + parentWidgets).toStdString());
    }

    // warn if source string wrapped, but UI adds text
    // TODO: add way to ignore this
    if (wrapped && text != TEST_TEXT) {
      WARN(("\"" + text + "\" is dynamic and needs a custom retranslate function. Parent widgets: " + parentWidgets).toStdString());
    }
  }
}

output:

<?xml version="1.0" encoding="UTF-8"?>
<Catch name="test_translations">
  <Group name="test_translations">
    <TestCase name="UI: test all strings wrapped" filename="selfdrive/ui/tests/test_translations.cc" line="39">
      <Failure filename="selfdrive/ui/tests/test_translations.cc" line="27">
        "Disengage on Accelerator Pedal" must be wrapped. Parent widgets: ParamControl->TogglesPanel->QWidget->ScrollView->QStackedWidget->SettingsWindow->MainWindow
      </Failure>
      <OverallResult success="false"/>
    </TestCase>
    <OverallResults successes="0" failures="1" expectedFailures="0"/>
    <OverallResultsCases successes="0" failures="1" expectedFailures="0"/>
  </Group>
  <OverallResults successes="0" failures="1" expectedFailures="0"/>
  <OverallResultsCases successes="0" failures="1" expectedFailures="0"/>
</Catch>

[nicoddemus]

Thanks @sshane!

[nicoddemus]

Released 2.6.0, thanks again!