Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement py>=1.4.22 is too low #105

Closed
jayvdb opened this issue Dec 31, 2016 · 4 comments · Fixed by #185
Closed

Requirement py>=1.4.22 is too low #105

jayvdb opened this issue Dec 31, 2016 · 4 comments · Fixed by #185

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Dec 31, 2016

setup.py requires py>=1.4.22 , and pytest>=2.7.0, however pytest 2.7.0 setup.py requires py>=1.4.25.

This causes problems as pip resolutions is not very good.
If someone installs pytest-xdist & pytest 2.7.0 together in that order, pip will use py>=1.4.22 and ignore py>=1.4.25. You can see that at https://travis-ci.org/jayvdb/my-ci-test/jobs/187902155

All is well if pytest-xdist bumps the requirement up to py>=1.4.25, and someone wants to install pytest 2.7.0 : See https://travis-ci.org/jayvdb/my-ci-test/builds/187901866 , which fakes that situation by first intalling py==1.4.25

However it fails again if someone wants to use the latest pytest , as it requires py>=1.4.29`. See https://travis-ci.org/jayvdb/my-ci-test/jobs/187913569#L241

@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 31, 2016

Note : pip does not have a dependency resolver : pypa/pip#988 ; it needs our help..

@RonnyPfannschmidt
Copy link
Member

Up for doing a PR?

@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 1, 2017

Sure, but do you want the incomplete solution of bumping up to py==1.4.25 , or py>=1.4.29.
The latter has been tested; see https://travis-ci.org/jayvdb/pytest-xdist/builds/188018807 .

@jayvdb
Copy link
Contributor Author

jayvdb commented Jul 14, 2017

This is now much worse, as the setup.py now requires pytest>=3.0.0, and the latest pytest requires py>=1.4.33.

The result is it is especially difficult to depend on pytest-xdist with a pre-existing pytest, such as using the default pytest provided by Travis.
See mementoweb/py-memento-client#13 for some major problems caused on Travis Python 2.7 and Python 3.4 environment.

jayvdb added a commit to jayvdb/pytest-xdist that referenced this issue Jul 14, 2017
`pytest-xdist` depends on `pytest>=3`.
`pytest 3.0.0` requires `py>=1.4.29`
and latest pytest requires `py>=1.4.33`.
Thus it is unnecessary for pytest-xdist to include
a requirement on `py>=1.4.22`

Fixes pytest-dev#105
jayvdb added a commit to jayvdb/pytest-xdist that referenced this issue Jul 14, 2017
`pytest-xdist` depends on `pytest>=3`.
`pytest 3.0.0` requires `py>=1.4.29`
and latest pytest requires `py>=1.4.33`.
Thus it is unnecessary for pytest-xdist to include
a requirement on `py>=1.4.22`

Fixes pytest-dev#105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants