Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'PytestPluginManager' object has no attribute 'notify_exception' #175

Closed
msarahan opened this issue Jun 29, 2017 · 6 comments
Closed

'PytestPluginManager' object has no attribute 'notify_exception' #175

msarahan opened this issue Jun 29, 2017 · 6 comments

Comments

@msarahan
Copy link

Seeing this with recent CI builds, not sure what the cause is. This happens on both Appveyor and Travis for me.

Appveyor: https://ci.appveyor.com/project/ContinuumAnalyticsFOSS/conda-build/build/1.0.2196/job/h78r7704romkxf7b#L748
Travis: https://travis-ci.org/conda/conda-build/jobs/248131289#L1430

pytest-xdist in use is 1.18.0: https://travis-ci.org/conda/conda-build/jobs/248131289#L902
pytest in use is 3.1.2: https://travis-ci.org/conda/conda-build/jobs/248131289#L898

Any hints much appreciated.

@nicoddemus
Copy link
Member

Thanks @msarahan for reporting.

Hmmm it seems this is a bug in pytest-xdist in here, this should be:

self.config.notify_exception(excinfo)

PytestPluginManager does not have that method at all. As this happen in an error handler it seems this is just hiding the real exception, the classic case of the error handler giving an error and shadowing the actual exception. 😓

We definitely should fix this for 1.18.1.

@zzzeek
Copy link

zzzeek commented Jul 26, 2017

I'm on 1.18.1 and getting this error like mad, I can no longer see test failures in my CI. It doesn't seem like any fix was committed here?

@RonnyPfannschmidt
Copy link
Member

indeed something went wrong there, i#ll try to take a look at fix*release today

@nicoddemus
Copy link
Member

It doesn't seem like any fix was committed here?

It wasn't, sorry about that.

Opened up a tentative fix at #194.

@nicoddemus
Copy link
Member

nicoddemus commented Jul 27, 2017

Note: my PR doesn't fix the reported problem (which we don't actually know what it is), with my PR at least xdist should be able to print the actual error before crashing down in flames. 🔥

@nicoddemus
Copy link
Member

1.18.2 has been released, thanks again for the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants