-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #4358 from blueyed/instance
Node: do not add "::()" to nodeid
- Loading branch information
Showing
8 changed files
with
50 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
Remove the ``::()`` notation to denote a test class instance in node ids. | ||
|
||
Previously, node ids that contain test instances would use ``::()`` to denote the instance like this:: | ||
|
||
test_foo.py::Test::()::test_bar | ||
|
||
The extra ``::()`` was puzzling to most users and has been removed, so that the test id becomes now:: | ||
|
||
test_foo.py::Test::test_bar | ||
|
||
This change could not accompany a deprecation period as is usual when user-facing functionality changes because | ||
it was not really possible to detect when the functionality was being used explicitly. | ||
|
||
The extra ``::()`` might have been removed in some places internally already, | ||
which then led to confusion in places where it was expected, e.g. with | ||
``--deselect`` (`#4127 <https://github.com/pytest-dev/pytest/issues/4127>`_). | ||
|
||
Test class instances are also not listed with ``--collect-only`` anymore. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters