Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 1496 - xfail with condition keyword #1524

Merged

Conversation

tomviner
Copy link
Contributor

Fix for #1496 Xfail does not work with condition keyword argument.

We were only looking at args, despite the docs saying:

Here’s the signature of the xfail marker, using Python 3 keyword-only arguments syntax:
def xfail(condition=None, *, reason=None, raises=None, run=True, strict=False):

@nicoddemus
Copy link
Member

Cool, many thanks! 😎

@nicoddemus
Copy link
Member

@RonnyPfannschmidt could you please take a look and merge if you are also OK with it?

@RonnyPfannschmidt
Copy link
Member

at first glance its ok will take a deeper look in a bit

@tomviner
Copy link
Contributor Author

@RonnyPfannschmidt I just simplified a little. I've rebased this branch, but I've pushed the edit here: tomviner@4b5640a

@nicoddemus
Copy link
Member

@RonnyPfannschmidt did you get a chance to take a better look on this? 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants