Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention omission of fixtures with leading '_', closes #3398 #3401

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Mention omission of fixtures with leading '_', closes #3398 #3401

merged 1 commit into from
Apr 16, 2018

Conversation

kohr-h
Copy link
Contributor

@kohr-h kohr-h commented Apr 14, 2018

I've added the corresponding text in a number of places, basically the ones that a text search for --fixtures brought up.
I didn't change the printout of FixtureLookupError, that would IMO be too much spamming and would have required changes to the tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 92.852% when pulling 6626d2a on kohr-h:underscore_fixtures into 36f6687 on pytest-dev:master.

nicoddemus
nicoddemus approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kohr-h!

@nicoddemus nicoddemus merged commit 159cd39 into pytest-dev:master Apr 16, 2018
@kohr-h kohr-h deleted the underscore_fixtures branch April 16, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kohr-h @coveralls @nicoddemus