Update mypy 0.740 -> 0.750 #6307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
commented
Dec 2, 2019
| @@ -479,7 +479,7 @@ def from_current( | |||
| assert tup[1] is not None, "no current exception" | |||
| assert tup[2] is not None, "no current exception" | |||
| exc_info = (tup[0], tup[1], tup[2]) | |||
| return cls.from_exc_info(exc_info, exprinfo) | |||
| return ExceptionInfo.from_exc_info(exc_info, exprinfo) | |||
There was a problem hiding this comment.
This is needed because it seems now cls is bound to the _E generic which is not compatible with BaseException. Using the type directly "unbounds" it.
nicoddemus
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes:
https://mypy-lang.blogspot.com/2019/11/mypy-0.html
Can remove existing workarounds, but unfortunately need to add some new ones.