Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cacheprovider: use warnings directly #6740

Merged
merged 2 commits into from
Feb 15, 2020
Merged

cacheprovider: use warnings directly #6740

merged 2 commits into from
Feb 15, 2020

Commits on Feb 15, 2020

  1. cacheprovider: use warnings directly 

    Allows for filtering of PytestCacheWarning.

Using `_issue_warning_captured` is not necessary here, and was probably
only used because the cacheprovider misses warnings during
`pytest_sessionfinish`, which is also fixed here.

I think the usage of `_issue_warning_captured` can be removed/reduced
further, but also that this is good enough for now.

Ref: pytest-dev#6681.
    @blueyed
    blueyed committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    02aa8ad View commit details
    Browse the repository at this point in the history

  2. Move test_issue4445_cacheprovider_set into test_cache_failure_warns 

    Would need to be adjusted anyway non-trivially, and we can just harden
`test_cache_failure_warns` instead.
    @blueyed
    blueyed committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    2b5adc8 View commit details
    Browse the repository at this point in the history